[PATCH] D46943: [clangd] Boost scores for decls from current file in completion

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

oops, just saw this is closed - will fix these nits as I'm touching this file soon



================
Comment at: clangd/Quality.h:68
+  /// Proximity between the best declaration and the query location. [0-1] score
+  /// where 1 is closest
+  float ProximityScore = 0;
----------------
(nit: trailing .)


================
Comment at: unittests/clangd/QualityTests.cpp:139
+  WithProximity.ProximityScore = 0.2;
+  EXPECT_LT(Default.evaluate(), WithProximity.evaluate());
 }
----------------
nit: can you EXPECT_GT and reverse the order? (default is on the right in all tests above, even the positive signals for symbolquality)


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D46943