[PATCH] D47707: [clangd] Downrank symbols with reserved names (score *= 0.1)

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 4 05:35:37 PDT 2018


ilya-biryukov added a comment.

After chatting offline: a FIXME mentioning some special cases seems enough here, we do improve the results in most cases (i.e. for queries that don't start with an underscore).

Another NIT:
Maybe we could add unittests for names that start with underscore, but are not considered reserved by our implementation?
I'm thinking about `"_"` and `"_non_upper_case_leading_char"`.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D47707





More information about the cfe-commits mailing list