[PATCH] D47460: [Frontend] Honor UserFilesAreVolatile flag getting file buffer in ASTUnit

Orgad Shaneh via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 4 02:24:49 PDT 2018


orgads added inline comments.


================
Comment at: unittests/Frontend/ASTUnitTest.cpp:21
 
+#define CREATE_AST_UNIT(isVolatile)                                            \
+  int FD;                                                                      \
----------------
Macros are evil. Maybe use TEST_F, and make these members of the base class?


https://reviews.llvm.org/D47460





More information about the cfe-commits mailing list