[PATCH] D41168: [X86] Lowering X86 avx512 sqrt intrinsics to IR

Simon Pilgrim via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jun 3 04:45:17 PDT 2018


RKSimon added inline comments.


================
Comment at: test/CodeGen/sse2-builtins.c:1199
   // CHECK-LABEL: test_mm_sqrt_sd
-  // CHECK: call <2 x double> @llvm.x86.sse2.sqrt.sd(<2 x double> %{{.*}})
-  // CHECK: extractelement <2 x double> %{{.*}}, i32 0
-  // CHECK: insertelement <2 x double> undef, double %{{.*}}, i32 0
-  // CHECK: extractelement <2 x double> %{{.*}}, i32 1
-  // CHECK: insertelement <2 x double> %{{.*}}, double %{{.*}}, i32 1
+  // CHECK-NOT: call <2 x double> @llvm.x86.sse2.sqrt.sd(<2 x double> %{{.*}})
+  // CHECK: extractelement <2 x double> %{{.*}}, i64 0
----------------
You've added CHECK-NOT to some (scalar only?) tests but not others - please be consistent.


Repository:
  rC Clang

https://reviews.llvm.org/D41168





More information about the cfe-commits mailing list