[PATCH] D47616: [CFG] [analyzer] Explain copy elision through construction contexts.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 1 15:25:05 PDT 2018


NoQ added inline comments.


================
Comment at: lib/Analysis/CFG.cpp:1320
+        auto *MTE = cast<MaterializeTemporaryExpr>(Child);
+        findConstructionContexts(ConstructionContextLayer::create(
+                                     cfg->getBumpVectorContext(), MTE, Layer),
----------------
NoQ wrote:
> george.karpenkov wrote:
> > There are three repeated calls to `findConstructionContexts`, with only the second argument changing. Perhaps a helper lambda closure would help?
> I'll look into this later for the whole function.
Aha, we are changing the whole function anyway, ok then.


https://reviews.llvm.org/D47616





More information about the cfe-commits mailing list