[PATCH] D47617: [Analyzer] Fix Z3ConstraintManager crash (PR37646)

Dominic Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 1 13:09:34 PDT 2018


ddcc added a comment.

In https://reviews.llvm.org/D47617#1119257, @george.karpenkov wrote:

> LGTM with a nit on a test name.


Same.

In https://reviews.llvm.org/D47617#1119268, @NoQ wrote:

> Also does this test need to be z3-specific? We would also not like to crash here without z3.


I had the same though originally about the `REQUIRES` line. Since this code path is very specific to Z3ConstraintManager, it didn't seem useful to run the test on normal buildbots. But I have no preference either way.


Repository:
  rC Clang

https://reviews.llvm.org/D47617





More information about the cfe-commits mailing list