[PATCH] D46845: [libcxx][c++17] P0083R5: Splicing Maps and Sets

Erik Pilkington via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 1 07:14:51 PDT 2018


erik.pilkington added inline comments.


================
Comment at: libcxx/include/__hash_table:2261
+_NodeHandle
+__hash_table<_Tp, _Hash, _Equal, _Alloc>::__node_handle_extract_unique(
+    key_type const& __key)
----------------
EricWF wrote:
> If I'm not mistaken, `__node_handle_extract_unique` and `__node_handle_extract_multi` have the exact same implementation. This is intentional, no? If so can't we just use one implementation? 
Yep, good point. The new patch just has `__node_handle_extract`.


https://reviews.llvm.org/D46845





More information about the cfe-commits mailing list