[PATCH] D47623: [clangd] Avoid indexing decls associated with friend decls.
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 1 05:20:57 PDT 2018
ilya-biryukov added inline comments.
================
Comment at: clangd/index/SymbolCollector.cpp:293
assert(CompletionAllocator && CompletionTUInfo);
+ // A declaration created for a friend declaration should not be used as the
+ // canonical declaration in the index.
----------------
Maybe move this closer to `shouldFilterDecl()`? We have similar filters there.
That would also mean we properly add the reference counts for friend declarations that get a normal declaration after their usage later.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47623
More information about the cfe-commits
mailing list