[PATCH] D47578: Do not enforce absolute path argv0 in windows

Rui Ueyama via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 31 11:24:21 PDT 2018


ruiu added inline comments.


================
Comment at: llvm/lib/Support/Windows/Process.inc:226
+
+static std::error_code GetLongArgv0Path(const wchar_t *Argv0,
+                                        SmallVectorImpl<const char *> &Args,
----------------
It looks like this function is a bit too complicated. I'd define a function that expands DOS-style 8.3 path and adds missing extension, and use that function.


https://reviews.llvm.org/D47578





More information about the cfe-commits mailing list