[PATCH] D47121: [NEON] Support VLD1xN intrinsics in AArch32 mode (Clang part)

[Sjoerd Meijer via Phabricator via cfe-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

I agree: these intrinsics are available in v7/A32/A64.



================
Comment at: lib/CodeGen/CGBuiltin.cpp:7865
   }
     // FIXME: Sharing loads & stores with 32-bit is complicated by the absence
     // of an Align parameter here.
----------------
kosarev wrote:
> SjoerdMeijer wrote:
> > How about this FIXME? Is it still relevant? And does it need to be moved up? Or perhaps better: move the code back here to minimise the diff?
> Yes, it's still true for the vst builtins handled below. None of the vld/vst patches removes this comment, but it should go away with whatever is the one to be committed last.
> 
> Umm, it seems leaving the vld code here wouldn't make the diff smaller?
ah yes, nevermind, got confused here.


https://reviews.llvm.org/D47121