[PATCH] D39398: [CFG][Analyzer] Add LoopExit element to the CFG in more cases

George Karpenkov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 30 16:56:12 PDT 2018


george.karpenkov requested changes to this revision.
george.karpenkov added inline comments.
This revision now requires changes to proceed.
Herald added a subscriber: dmgreen.


================
Comment at: lib/Analysis/CFG.cpp:1348
+    for (auto &Parent : ASTCtx.getParents(Node)) {
+      NodesToVisit.push(Parent);
+    }
----------------
shouldn't we have a `visited` list as well, to avoid exponential queue explosion if nodes are repeated?


https://reviews.llvm.org/D39398





More information about the cfe-commits mailing list