[PATCH] D47350: [analyzer] Track class member initializer constructors path-sensitively within their construction context.
George Karpenkov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 30 16:17:07 PDT 2018
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
LGTM, but I would really prefer if you could split that inheritance back into composition.
================
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:123
+/// AST nodes.
+class ConstructedObjectKey : public ConstructedObjectKeyImpl {
+ const void *getAnyASTNodePtr() const {
----------------
sorry I find that very confusing, and I think the previous version was better (prefer composition over inheritance)
https://reviews.llvm.org/D47350
More information about the cfe-commits
mailing list