[PATCH] D47121: [NEON] Support VLD1xN intrinsics in AArch32 mode (Clang part)

[Sjoerd Meijer via Phabricator via cfe-commits]

SjoerdMeijer added a comment.

Had only a first brief look; see some first drive by comments inline.



================
Comment at: lib/CodeGen/CGBuiltin.cpp:7865
   }
     // FIXME: Sharing loads & stores with 32-bit is complicated by the absence
     // of an Align parameter here.
----------------
How about this FIXME? Is it still relevant? And does it need to be moved up? Or perhaps better: move the code back here to minimise the diff?


================
Comment at: test/CodeGen/arm-neon-vld.c:4
+// RUN:     FileCheck -check-prefixes=CHECK,CHECK-A64 %s
+// RUN: %clang_cc1 -triple armv8-none-linux-gnueabi -target-feature +neon \
+// RUN:     -S -disable-O0-optnone -emit-llvm -o - %s | opt -S -mem2reg | \
----------------
Should this be armv7?


https://reviews.llvm.org/D47121