[PATCH] D47233: [CodeGen] Emit MSVC RTTI for Obj-C EH types

Dustin L. Howett via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 29 18:16:46 PDT 2018


DHowett-MSFT accepted this revision.
DHowett-MSFT added a comment.
This revision is now accepted and ready to land.

This largely matches what we've done in the WinObjC clang patchset here <https://github.com/Microsoft/WinObjC/blob/develop/contrib/clang/patches/0018-ObjCGNU-Add-the-bulk-of-CGObjCMicrosoft.patch#L84>, with the critical exception that we've chosen to mangle the EH names as though they were for structs named after their classes.

Is there some safe generalization that will apply well to all Objective-C runtimes, and that we could put in a common place?

Overall, the change seems reasonable to me, but my signoff cannot constitute strong-enough acceptance.


Repository:
  rC Clang

https://reviews.llvm.org/D47233





More information about the cfe-commits mailing list