[PATCH] D47190: [Driver] Add -ivfsoverlay-lib option to load VFS from shared library

[Jonas Devlieghere via Phabricator via cfe-commits]

JDevlieghere added a comment.

I don't know much about the VFS so I only did a superficial review.



================
Comment at: include/clang/Lex/HeaderSearchOptions.h:176
 
+  /// \brief The set of libraries with user-provided virtual filesystem.
+  std::vector<std::string> VFSOverlayLibs;
----------------
We now have autobrief enabled so you can omit the `\brief`. 


================
Comment at: lib/Frontend/CompilerInvocation.cpp:3218
+  for (const std::string &LibFile : CI.getHeaderSearchOpts().VFSOverlayLibs) {
+    std::string Error;
+    auto Lib = llvm::sys::DynamicLibrary::getPermanentLibrary(
----------------
Would it be useful to print the contents of the error?


================
Comment at: unittests/Frontend/VfsTestLib.cpp:24
+  std::error_code EC = llvm::sys::fs::make_absolute(FileName);
+  if (EC) {
+    return nullptr;
----------------
The llvm coding standard says no braces for single line statements. 


Repository:
  rC Clang

https://reviews.llvm.org/D47190