[PATCH] D46052: GNUstep Objective-C ABI version 2

[Dávid Bolvanský via Phabricator via cfe-commits]

xbolva00 added inline comments.


================
Comment at: lib/CodeGen/CGObjCGNU.cpp:512
   /// used to return an untyped selector (with the types field set to NULL).
-  llvm::Value *GetSelector(CodeGenFunction &CGF, Selector Sel,
+  virtual llvm::Value *GetSelector(CodeGenFunction &CGF, Selector Sel,
                            const std::string &TypeEncoding);
----------------
theraven wrote:
> xbolva00 wrote:
> > This causes 
> > CGObjCGNU.cpp:589:16: warning: ‘virtual llvm::Value* {anonymous}::CGObjCGNU::GetSelector(clang::CodeGen::CodeGenFunction&, const clang::ObjCMethodDecl*)’ was hidden [-Woverloaded-virtual]
> >    llvm::Value *GetSelector(CodeGenFunction &CGF,
> > 
> I can't reproduce this, and I'm not sure what the issue is.  The two lines have different overloads, so one shouldn't be hiding the other.
It is a warning from GCC 7.2


Repository:
  rC Clang

https://reviews.llvm.org/D46052