[PATCH] D47299: [CodeGenCXX] Emit strip.invariant.group with -fstrict-vtable-pointers

Piotr Padlewski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 25 17:44:49 PDT 2018


Prazek added inline comments.


================
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1626-1627
+
+      // Casting to pointer that does not carry dynamic information (provided by
+      // invariant.group) requires stripping it.
+      Src = Builder.CreateStripInvariantGroup(Src);
----------------
rsmith wrote:
> Are there any cases where we need a barrier when the destination type is a dynamic type here?
No, I don't think so. I will also add test for that.


Repository:
  rL LLVM

https://reviews.llvm.org/D47299





More information about the cfe-commits mailing list