[PATCH] D46895: add AR to acronyms of clang-tidy property check
Stephane Moore via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri May 25 16:15:19 PDT 2018
stephanemoore added inline comments.
================
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:37-38
/// The acronyms are from
/// https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/CodingGuidelines/Articles/APIAbbreviations.html#//apple_ref/doc/uid/20001285-BCIHCGAE
///
----------------
This comment does not seem to be accurate anymore. The acronyms in this list are not all from the linked Apple documentation.
Sent out https://reviews.llvm.org/D46922.
================
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:45
"API",
+ "AR",
"ARGB",
----------------
Are we sure it's sustainable to keep growing this list of acronyms? I suspect there may be enough domain-specific acronyms that it might be better to accept any sequence of capitalized alphanumeric characters as an acronym.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46895
More information about the cfe-commits
mailing list