[PATCH] D47229: Make atomic non-member functions as nonnull
Alex Lorenz via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 23 18:15:40 PDT 2018
arphaman added inline comments.
================
Comment at: lib/Sema/SemaChecking.cpp:3497
+ else if (Form == Copy || Form == Xchg) {
+ if (!IsC11 && !IsN)
+ // The value pointer is always dereferenced, a nullptr is undefined.
----------------
Nit: might make more sense to check if `ByValType` is a pointer here instead of duplicating the `if` condition from above.
Repository:
rC Clang
https://reviews.llvm.org/D47229
More information about the cfe-commits
mailing list