[PATCH] D46667: [OpenCL, OpenMP] Fix crash when OpenMP used in OpenCL file

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: test/SemaOpenCL/with_openmp.cl:1
+// RUN: %clang_cc1 -verify -fopenmp -ast-dump -x cl %s 2>&1 | FileCheck %s
+// expected-no-diagnostics
----------------
mikerice wrote:
> ABataev wrote:
> > Still the same question, do we really want to support full OpenMP for OpenCL or only simd?
> We think it makes sense to have full support.  We are using OpenCL for devices that can run full OpenMP.  Is there any known problem with allowing full support?    
Sounds good! What target do you use though? Would it help to have an IR test as well?


https://reviews.llvm.org/D46667