[PATCH] D47057: [ASTImporter] Fix missing implict CXXRecordDecl in ClassTemplateSpecializationDecl
Aleksei Sidorin via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue May 22 09:31:59 PDT 2018
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
LGTM with a nit.
================
Comment at: lib/AST/ASTImporter.cpp:1962
TagDecl *Definition = D->getDefinition();
- if (Definition && Definition != D) {
+ if (!D->isImplicit() /*In contrast to a normal CXXRecordDecl, the implicit
+ CXXRecordDecl of ClassTemplateSpecializationDecl is its redeclaration.
----------------
Multiline comments are pretty uncommon in LLVM. Could you please replace it with `//` before commit? I.e.
```
if (Definition && Definition != D &&
//
//
!D->isImplicit())
```
Repository:
rC Clang
https://reviews.llvm.org/D47057
More information about the cfe-commits
mailing list