[PATCH] D47099: Call CreateTempAllocaWithoutCast for ActiveFlag

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added a comment.

I revert it since it caused regression on arm and some other arch's.

  Script:
  --
  /home/ssglocal/clang-cmake-x86_64-avx2-linux/clang-cmake-x86_64-avx2-linux/stage1/bin/clang -cc1 -internal-isystem /home/ssglocal/clang-cmake-x86_64-avx2-linux/clang-cmake-x86_64-avx2-linux/stage1/lib/clang/7.0.0/include -nostdsysteminc -emit-llvm /home/ssglocal/clang-cmake-x86_64-avx2-linux/clang-cmake-x86_64-avx2-linux/llvm/tools/clang/test/CodeGenCXX/conditional-temporaries.cpp -o - -triple=x86_64-apple-darwin9 -O3 | /home/ssglocal/clang-cmake-x86_64-avx2-linux/clang-cmake-x86_64-avx2-linux/stage1/bin/FileCheck /home/ssglocal/clang-cmake-x86_64-avx2-linux/clang-cmake-x86_64-avx2-linux/llvm/tools/clang/test/CodeGenCXX/conditional-temporaries.cpp
  /home/ssglocal/clang-cmake-x86_64-avx2-linux/clang-cmake-x86_64-avx2-linux/stage1/bin/clang -cc1 -internal-isystem /home/ssglocal/clang-cmake-x86_64-avx2-linux/clang-cmake-x86_64-avx2-linux/stage1/lib/clang/7.0.0/include -nostdsysteminc -emit-llvm /home/ssglocal/clang-cmake-x86_64-avx2-linux/clang-cmake-x86_64-avx2-linux/llvm/tools/clang/test/CodeGenCXX/conditional-temporaries.cpp -o - -triple=amdgcn-amd-amdhsa -O3 | /home/ssglocal/clang-cmake-x86_64-avx2-linux/clang-cmake-x86_64-avx2-linux/stage1/bin/FileCheck /home/ssglocal/clang-cmake-x86_64-avx2-linux/clang-cmake-x86_64-avx2-linux/llvm/tools/clang/test/CodeGenCXX/conditional-temporaries.cpp
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /home/ssglocal/clang-cmake-x86_64-avx2-linux/clang-cmake-x86_64-avx2-linux/llvm/tools/clang/test/CodeGenCXX/conditional-temporaries.cpp:42:12: error: expected string not found in input
   // CHECK: ret i32 5
             ^
  <stdin>:11:33: note: scanning from here
  define i32 @_Z12getCtorCallsv() local_unnamed_addr #0 {
                                  ^
  <stdin>:14:2: note: possible intended match here
   ret i32 %0
   ^
  /home/ssglocal/clang-cmake-x86_64-avx2-linux/clang-cmake-x86_64-avx2-linux/llvm/tools/clang/test/CodeGenCXX/conditional-temporaries.cpp:48:12: error: expected string not found in input
   // CHECK: ret i32 5
             ^
  <stdin>:18:33: note: scanning from here
  define i32 @_Z12getDtorCallsv() local_unnamed_addr #0 {
                                  ^
  <stdin>:21:2: note: possible intended match here
   ret i32 %0
   ^
  /home/ssglocal/clang-cmake-x86_64-avx2-linux/clang-cmake-x86_64-avx2-linux/llvm/tools/clang/test/CodeGenCXX/conditional-temporaries.cpp:54:12: error: expected string not found in input
   // CHECK: ret i1 true
             ^
  <stdin>:25:34: note: scanning from here
  define zeroext i1 @_Z7successv() local_unnamed_addr #0 {
                                   ^
  <stdin>:30:2: note: possible intended match here
   ret i1 %cmp
   ^
  
  --

Strange thing is that this only happens on some arch's. It passes on my x86_64/ubuntu built with clang.


Repository:
  rC Clang

https://reviews.llvm.org/D47099