[PATCH] D47200: [Sema] Add tests for weak functions

Jonas Hahnfeld via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 22 08:51:06 PDT 2018


Hahnfeld created this revision.
Hahnfeld added reviewers: aaron.ballman, rjmccall.
Herald added a subscriber: cfe-commits.

I found these checks to be missing, just add some simple cases.


Repository:
  rC Clang

https://reviews.llvm.org/D47200

Files:
  test/Sema/attr-weak.c


Index: test/Sema/attr-weak.c
===================================================================
--- test/Sema/attr-weak.c
+++ test/Sema/attr-weak.c
@@ -1,7 +1,9 @@
 // RUN: %clang_cc1 -verify -fsyntax-only %s
 
+extern int f0() __attribute__((weak));
 extern int g0 __attribute__((weak));
 extern int g1 __attribute__((weak_import));
+int f2() __attribute__((weak));
 int g2 __attribute__((weak));
 int g3 __attribute__((weak_import)); // expected-warning {{'weak_import' attribute cannot be specified on a definition}}
 int __attribute__((weak_import)) g4(void);
@@ -11,6 +13,7 @@
 struct __attribute__((weak)) s0 {}; // expected-warning {{'weak' attribute only applies to variables, functions, and classes}}
 struct __attribute__((weak_import)) s1 {}; // expected-warning {{'weak_import' attribute only applies to variables and functions}}
 
+static int f() __attribute__((weak)); // expected-error {{weak declaration cannot have internal linkage}}
 static int x __attribute__((weak)); // expected-error {{weak declaration cannot have internal linkage}}
 
 // rdar://9538608


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47200.148021.patch
Type: text/x-patch
Size: 1078 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180522/d9bcbf64/attachment.bin>


More information about the cfe-commits mailing list