[PATCH] D46541: [CodeGen] Improve diagnostics related to target attributes
Gabor Buella via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue May 22 04:57:10 PDT 2018
GBuella added a comment.
In https://reviews.llvm.org/D46541#1106743, @craig.topper wrote:
> I think you can pass StringRef(F).substr(1). That won't create a temporary string. It will just create a StringRef pointing into the middle of an existing std::string stored in the parsed attributes.
Yes, that seems to work.
https://reviews.llvm.org/D46541
More information about the cfe-commits
mailing list