[PATCH] D47103: Implement strip.invariant.group

[Krzysztof Pszeniczny via Phabricator via cfe-commits]

amharc added inline comments.


================
Comment at: clang/include/clang/AST/DeclCXX.h:778
 
+  bool mayBeDynamicClass() const {
+    return !isCompleteDefinition() || isDynamicClass();
----------------
xbolva00 wrote:
> maybeDynamicClass?
> 
> https://github.com/llvm-mirror/llvm/search?utf8=%E2%9C%93&q=maybe&type=
I think `mayBe` is more appropriate, because it grammatically consists of 'may' and 'be'. In this form it appears in multiple places in the codebase, too. A few examples:

https://github.com/llvm-mirror/llvm/blob/0b24b74655b976aaba01b2f726659b8c745a16de/include/llvm/IR/GlobalValue.h#L131
https://github.com/llvm-mirror/clang/blob/647be32c6048e24f90f470c557e850597e5526c3/lib/AST/DeclCXX.cpp#L1800
https://github.com/llvm-mirror/llvm/blob/77438c3c98c0901fa9ef56f78bdefccedc16fcc4/lib/Analysis/ValueTracking.cpp#L3659


Repository:
  rL LLVM

https://reviews.llvm.org/D47103