[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

[Jake Ehrlich via Phabricator via cfe-commits]

jakehehrlich added a comment.

LGTM with a couple additions.



================
Comment at: lib/CodeGen/CodeGenTypes.cpp:448
+    case BuiltinType::ULongAccum:
       ResultType = llvm::IntegerType::get(getLLVMContext(),
                                  static_cast<unsigned>(Context.getTypeSize(T)));
----------------
Add TODO for accum types using a different drawf type.


================
Comment at: lib/Index/USRGeneration.cpp:731
+
+      if (c == '~') {
+        switch (BT->getKind()) {
----------------
You can make the 'c' a Twine instead. That will let you inline these in their respective locations as `  c = "~UA" ` for instance.


Repository:
  rC Clang

https://reviews.llvm.org/D46084