[PATCH] D47150: [Clang Tablegen] Add llvm_unreachable() to getModifierName()

Mark Searles via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 21 10:05:36 PDT 2018


msearles updated this revision to Diff 147807.
msearles retitled this revision from "[Clang Tablegen] Add default case to getModifierName()" to "[Clang Tablegen]  Add llvm_unreachable() to getModifierName()".
msearles added a comment.

Ah, yes. Adding llvm_unreachable() is better. Done.


https://reviews.llvm.org/D47150

Files:
  utils/TableGen/ClangDiagnosticsEmitter.cpp


Index: utils/TableGen/ClangDiagnosticsEmitter.cpp
===================================================================
--- utils/TableGen/ClangDiagnosticsEmitter.cpp
+++ utils/TableGen/ClangDiagnosticsEmitter.cpp
@@ -492,6 +492,7 @@
   case MT_Unknown:
     llvm_unreachable("invalid modifier type");
   }
+  llvm_unreachable("invalid modifier type");
 }
 
 struct Piece {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47150.147807.patch
Type: text/x-patch
Size: 372 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180521/bdf1d506/attachment-0001.bin>


More information about the cfe-commits mailing list