[PATCH] D47142: [x86] invpcid intrinsic

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 21 09:50:06 PDT 2018


rnk added a comment.

Why do we need a feature flag for this in the first place? The MSVC model for most "instruction" intrinsics is that the exact instruction is emitted regardless of the feature enabled. The target attribute seems like it would get in the way of that.



================
Comment at: lib/Headers/intrin.h:196
+ */
 void __cdecl _invpcid(unsigned int, void *);
+#endif
----------------
craig.topper wrote:
> @rnk, what's the right thing to do here?
What problems does this redeclaration cause?


Repository:
  rC Clang

https://reviews.llvm.org/D47142





More information about the cfe-commits mailing list