[PATCH] D46910: [Support] Avoid normalization in sys::getDefaultTargetTriple

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

This changes the default triple on Windows from x86_64-pc-win32 to x86_64-pc-windows-msvc. This breaks at least lit's make_itanium_abi_triple() (http://llvm-cs.pcc.me.uk/utils/lit/lit/llvm/config.py#234)

  def make_itanium_abi_triple(self, triple):
      m = re.match(r'(\w+)-(\w+)-(\w+)', triple)
      if not m:
          self.lit_config.fatal(
              "Could not turn '%s' into Itanium ABI triple" % triple)
      if m.group(3).lower() != 'win32':
          # All non-win32 triples use the Itanium ABI.
          return triple
      return m.group(1) + '-' + m.group(2) + '-mingw32'

which in turn breaks %itanium_abi_triple in lit tests, which then breaks some 257 tests on Windows.

(Also visible on http://lab.llvm.org:8011/builders/clang-x64-ninja-win7 , but that bot has been broken for a long time.)

So I'll revert this for now.


Repository:
  rC Clang

https://reviews.llvm.org/D46910