[PATCH] D47099: Disable casting of alloca for ActiveFlag

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added a comment.

In https://reviews.llvm.org/D47099#1105493, @rjmccall wrote:

> Maybe there should just be a method that makes a primitive alloca without the casting, and then you can call that in CreateTempAlloca.


In many cases we still need to call CreateTempAlloca with cast enabled, since we are not certain there is only load from it and store to it. Any time it is stored to another memory location or passed to another function (e.g. constructor/destructor), it needs to be a pointer to  the language's default address space since the language sees it that way.


https://reviews.llvm.org/D47099