[PATCH] D47096: CodeGen: block capture shouldn't ICE

JF Bastien via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 18 21:07:42 PDT 2018


jfb added a comment.

In https://reviews.llvm.org/D47096#1105455, @rjmccall wrote:

> `children()` is actually defined at the `Stmt` level, and if you look at how it's implemented on e.g. `IfStmt`, you can see that it visits all of the child `Stmt`s, including the if-condition.  So it should be fine.


Thanks for pointing this out! I was reading the code but missed that, and visitor seemed like the only reliable way to do what I wanted. Here's an update patch.


Repository:
  rC Clang

https://reviews.llvm.org/D47096





More information about the cfe-commits mailing list