[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type
Leonard Chan via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 17 15:39:49 PDT 2018
leonardchan updated this revision to Diff 147400.
leonardchan added a comment.
Added break. We still assign `Result` since it cannot be null at the end of the switch stmt, though the value doesn't matter.
Added character `~` to indicate fixed point type followed by string detailing the type. I have not added a test to it because logically, I do not think we will ever reach that point. This logic is implemented in the `VisitType` method, which mostly gets called by visitors to c++ nodes like `VisitTemplateParameterList`, but we have disabled the use of fixed point types in c++. `VisitType` does get called in `VisitFunctionDecl` but the function exits early since we are not reading c++ (line lib/Index/USRGeneration.cpp:238).
Repository:
rC Clang
https://reviews.llvm.org/D46084
Files:
include/clang-c/Index.h
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
include/clang/Basic/DiagnosticCommonKinds.td
include/clang/Basic/Specifiers.h
include/clang/Basic/TokenKinds.def
include/clang/Sema/DeclSpec.h
include/clang/Serialization/ASTBitCodes.h
lib/AST/ASTContext.cpp
lib/AST/ExprConstant.cpp
lib/AST/ItaniumMangle.cpp
lib/AST/MicrosoftMangle.cpp
lib/AST/NSAPI.cpp
lib/AST/Type.cpp
lib/AST/TypeLoc.cpp
lib/Analysis/PrintfFormatString.cpp
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CodeGenTypes.cpp
lib/CodeGen/ItaniumCXXABI.cpp
lib/Index/USRGeneration.cpp
lib/Parse/ParseDecl.cpp
lib/Sema/DeclSpec.cpp
lib/Sema/SemaTemplateVariadic.cpp
lib/Sema/SemaType.cpp
lib/Serialization/ASTCommon.cpp
lib/Serialization/ASTReader.cpp
test/Frontend/accum.c
test/Frontend/accum_errors.c
test/Frontend/accum_errors.cpp
tools/libclang/CXType.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46084.147400.patch
Type: text/x-patch
Size: 32155 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180517/3c5668bd/attachment-0001.bin>
More information about the cfe-commits
mailing list