[PATCH] D46659: [clang-tidy/google-readability-casting] Disable check for Objective-C++

[Ben Hamilton via Phabricator via cfe-commits]

benhamilton added inline comments.


================
Comment at: clang-tidy/google/AvoidCStyleCastsCheck.cpp:103-104
   // The rest of this check is only relevant to C++.
-  if (!getLangOpts().CPlusPlus)
+  // We also disable it for Objective-C++.
+  if (!getLangOpts().CPlusPlus || getLangOpts().ObjC1 || getLangOpts().ObjC2)
     return;
----------------
stephanemoore wrote:
> In the future it would probably be good to allow configuring whether or not this is disabled but I think that disabling it for Objective-C++ completely in the interim is a positive change.
Agreed. Filed https://bugs.llvm.org/show_bug.cgi?id=37489 to follow up.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D46659