[PATCH] D46943: [clangd] Boost scores for decls from current file in completion
Eric Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 16 07:34:04 PDT 2018
ioeric added inline comments.
================
Comment at: clangd/Quality.cpp:24
+ if (SemaCCResult.Declaration)
+ AllDeclsInMainFile = allDeclsInMainFile(SemaCCResult.Declaration);
if (SemaCCResult.Availability == CXAvailability_Deprecated)
----------------
Could you explain why `AllDeclsInMainFile` is necessary? I think it might still be fine to boost score for symbols with a declaration in the main file even if it has redecls in other files (e.g. function fwd in headers).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46943
More information about the cfe-commits
mailing list