[PATCH] D46835: [ASTImporter] Do not try to remove invisible Decls from DeclContext

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 16 06:12:59 PDT 2018


aaron.ballman added a comment.

Can you roll back the changes in MatchVerifier.h? Phab is telling me that the only changes are to whitespace.



================
Comment at: lib/AST/DeclBase.cpp:1353
 
+static bool shouldBeHidden(NamedDecl *D);
+
----------------
Rather than make a hanging forward declaration, can you just move the definition of this function here?


================
Comment at: lib/AST/DeclBase.cpp:1387
+    // lookup.  E.g. template specializations are skipped.
+    if (shouldBeHidden(ND)) return;
+
----------------
The `return` should be on its own line per our usual conventions.


Repository:
  rC Clang

https://reviews.llvm.org/D46835





More information about the cfe-commits mailing list