r332421 - Revert commits r332160, r332164, r332236.
Douglas Yung via cfe-commits
cfe-commits at lists.llvm.org
Tue May 15 17:27:44 PDT 2018
Author: dyung
Date: Tue May 15 17:27:43 2018
New Revision: 332421
URL: http://llvm.org/viewvc/llvm-project?rev=332421&view=rev
Log:
Revert commits r332160, r332164, r332236.
It was decided this is the wrong approach to fix this issue.
Removed:
cfe/trunk/test/Driver/clang-abi-compat.cpp
Modified:
cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td
cfe/trunk/lib/Frontend/CompilerInvocation.cpp
cfe/trunk/test/CodeGenCXX/alignment.cpp
Modified: cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td?rev=332421&r1=332420&r2=332421&view=diff
==============================================================================
--- cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td (original)
+++ cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td Tue May 15 17:27:43 2018
@@ -150,9 +150,6 @@ def warn_drv_unknown_argument_clang_cl :
def warn_drv_unknown_argument_clang_cl_with_suggestion : Warning<
"unknown argument ignored in clang-cl '%0' (did you mean '%1'?)">,
InGroup<UnknownArgument>;
-def warn_drv_ignored_clang_abi_version : Warning<
- "target requires clang ABI version %0, ignoring requested version">,
- InGroup<UnusedCommandLineArgument>;
def warn_drv_ycyu_no_arg_clang_cl : Warning<
"support for '%0' without a filename not implemented yet; flag ignored">,
Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/CompilerInvocation.cpp?rev=332421&r1=332420&r2=332421&view=diff
==============================================================================
--- cfe/trunk/lib/Frontend/CompilerInvocation.cpp (original)
+++ cfe/trunk/lib/Frontend/CompilerInvocation.cpp Tue May 15 17:27:43 2018
@@ -2751,16 +2751,6 @@ static void ParseLangArgs(LangOptions &O
<< A->getAsString(Args) << A->getValue();
}
}
- // The PS4 requires version 6 of the clang ABI.
- if (T.isPS4()) {
- // Issue a warning if another version of the ABI was requested.
- if (Args.getLastArg(OPT_fclang_abi_compat_EQ) &&
- Opts.getClangABICompat() != LangOptions::ClangABI::Ver6) {
- Diags.Report(diag::warn_drv_ignored_clang_abi_version)
- << 6;
- }
- Opts.setClangABICompat(LangOptions::ClangABI::Ver6);
- }
}
static bool isStrictlyPreprocessorAction(frontend::ActionKind Action) {
Modified: cfe/trunk/test/CodeGenCXX/alignment.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/alignment.cpp?rev=332421&r1=332420&r2=332421&view=diff
==============================================================================
--- cfe/trunk/test/CodeGenCXX/alignment.cpp (original)
+++ cfe/trunk/test/CodeGenCXX/alignment.cpp Tue May 15 17:27:43 2018
@@ -1,8 +1,5 @@
// RUN: %clang_cc1 %s -emit-llvm -o - -triple=x86_64-apple-darwin10 | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-NOCOMPAT
// RUN: %clang_cc1 %s -emit-llvm -o - -triple=x86_64-apple-darwin10 -fclang-abi-compat=6.0 | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-V6COMPAT
-// Check that the PS4 target uses the 6.0 compat settings.
-// RUN: %clang_cc1 %s -emit-llvm -o - -triple=x86_64-scei-ps4 | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-V6COMPAT
-// RUN: %clang_cc1 %s -emit-llvm -o - -triple=x86_64-scei-ps4 -fclang-abi-compat=latest | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-V6COMPAT
extern int int_source();
extern void int_sink(int x);
Removed: cfe/trunk/test/Driver/clang-abi-compat.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/clang-abi-compat.cpp?rev=332420&view=auto
==============================================================================
--- cfe/trunk/test/Driver/clang-abi-compat.cpp (original)
+++ cfe/trunk/test/Driver/clang-abi-compat.cpp (removed)
@@ -1,8 +0,0 @@
-// PS4 target requires clang ABI version 6, check that a warning is emitted when a version other than 6 is requested.
-// RUN: %clang -S --target=x86_64-scei-ps4 -fclang-abi-compat=4 %s -o /dev/null 2>&1 | FileCheck %s -check-prefix=CHECK-WARNING
-// RUN: %clang -S --target=x86_64-scei-ps4 -fclang-abi-compat=latest %s -o /dev/null 2>&1 | FileCheck %s -check-prefix=CHECK-WARNING
-
-// REQUIRES: x86-registered-target
-
-// CHECK-WARNING: warning: target requires clang ABI version 6, ignoring requested version
-
More information about the cfe-commits
mailing list