[PATCH] D46903: [Attr] Don't print attr arg with default value

Joel E. Denny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 15 14:06:18 PDT 2018


jdenny added a comment.

I occurs to me now that I could have fixed __single_inheritance by declaring its argument "fake".  However, I still prefer the above solution because (1) it should help with any other attributes where arguments should have been declared fake (but no, I haven't identified any yet), and (2) it generally makes attribute printing more succinct, including cases where originally implicit values were printing as explicit.  Again, the sacrifice is that some explicit values now print as implicit, but at least the semantics don't change.

If others disagree, I can change this.


https://reviews.llvm.org/D46903





More information about the cfe-commits mailing list