[PATCH] D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts

Jan Korous via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 15 10:19:23 PDT 2018


jkorous planned changes to this revision.
jkorous added a comment.

Sorry for me being dense here - since the output format is determined by input source code there's more work to do.

I tried to change format of introduced version in couple of tests and the output mirrors the change. That basically means that whenever someone uses underscore

  __attribute__((availability(macosx, introduced = 10_12)))

instead of dot

  __attribute__((availability(macosx, introduced = 10.12)))

Warnings and FixIts get underscore as well.

I am now thinking about just switching to dot format in ParseAvailabilityAttribute() because it's much simpler to maintain consistency that way.


https://reviews.llvm.org/D46747





More information about the cfe-commits mailing list