[PATCH] D46835: [ASTImporter] Do not try to remove invisible Decls from DeclContext

[Gabor Marton via Phabricator via cfe-commits]

martong added a comment.

Hi Aleksei,

Thanks for reviewing this.
I could synthesize a test which exercises only the `DeclContext::removeDecl` function. This test causes an assertion without the fix.
Removed the rest of the testcases, which are not strictly connected to this change.



================
Comment at: unittests/AST/ASTImporterTest.cpp:1827
+
+TEST_P(ASTImporterTestBase, DISABLED_ImportOfRecordWithDifferentFriends) {
+  Decl *ToR1;
----------------
a.sidorin wrote:
> For this change, we should create a separate patch.
This test is disabled ATM, but I agree it would be better to bring this in when we fix the import of friends.


Repository:
  rC Clang

https://reviews.llvm.org/D46835