[PATCH] D46836: Fix some rtti-options tests

Filipe Cabecinhas via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 15 06:58:55 PDT 2018


filcab accepted this revision.
filcab added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/Driver/rtti-options.cpp:13
 // RUN: %clang -### -c -fno-rtti -frtti %s 2>&1 | FileCheck -check-prefix=CHECK-RTTI %s
-// RUN: %clang -### -c -frtti -fno-rtti %s 2>&1 | FileCheck -check-prefix=CHECK-NO-RTTI %s
+// RUN: %clang -### -c -frtti -fno-rtti %s 2>&1 | FileCheck -check-prefix=CHECK-RTTI-NOT %s
 
----------------
Minor nit: I like saving space like that, but I think it might be slightly confusing for someone reading this, as the `-NOT` suffix is special in `FileCheck`. I don't think this is a huge problem as we have the single CHECK line, and we don't end up using `...-NOT-NOT` anyway.
Feel free to keep or change as you want.


Repository:
  rC Clang

https://reviews.llvm.org/D46836





More information about the cfe-commits mailing list