[PATCH] D46643: CodeGen: Emit string literal in constant address space

[John McCall via Phabricator via cfe-commits]

rjmccall added inline comments.


================
Comment at: lib/CodeGen/CGDecl.cpp:1373
+  llvm::Type *BP = llvm::Type::getInt8Ty(CGM.getLLVMContext())
+                       ->getPointerTo(Loc.getAddressSpace());
   if (Loc.getType() != BP)
----------------
`CGM.Int8Ty` exists.


================
Comment at: lib/CodeGen/CodeGenModule.cpp:3077
+  return Cast;
+}
+
----------------
This should really just be a `static` function in this file.


https://reviews.llvm.org/D46643