[PATCH] D46496: [Tooling] Pull #include manipulation code from clangFormat into libToolingCore.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 14 08:38:11 PDT 2018


ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Format/Format.cpp:1702
   // cases where the first #include is unlikely to be the main header.
-  IncludeCategoryManager Categories(Style, FileName);
+  tooling::IncludeCategoryManager Categories(Style.IncludeStyle, FileName);
   bool FirstIncludeBlock = true;
----------------
ilya-biryukov wrote:
> It seems `Style.IncludeStyle` should be in the other change that pulls out `IncludeStyle` from `FormatStyle`.
> Or am I missing something?
As chatted offline, we need this to pull out `IncludeCategoryManager` out of Format.cpp.
That should be the only change in this commit, other than moving the code around, so there's no need to pull it into a separate commit.


Repository:
  rC Clang

https://reviews.llvm.org/D46496





More information about the cfe-commits mailing list