[PATCH] D46353: [ASTImporter] Extend lookup logic in class templates
Aleksei Sidorin via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon May 14 08:32:44 PDT 2018
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D46353#1086456, @martong wrote:
> > should we add this new declaration to the redeclaration chain like we do it for RecordDecls?
>
> I think, on a long term we should. Otherwise we could loose e.g. C++11 attributes which are attached to the forward declaration only.
> However, I'd do that as a separate commit, because that would require some independent changes and tests, also other decl kinds like ClassTemplateSepcializationDecl may be affected as well by that.
I'm fine with this. But a FIXME would be very appreciated.
Repository:
rC Clang
https://reviews.llvm.org/D46353
More information about the cfe-commits
mailing list