[PATCH] D46805: If some platforms do not support an attribute, we should exclude the platform

[Li Jia He via Phabricator via cfe-commits]

HLJ2009 added inline comments.


================
Comment at: include/clang/Basic/Attr.td:566-567
 
-def Alias : Attr {
+// We do not support alias attribute on Apple platform, so we exclude the platform.
+def Alias : Attr, TargetSpecificAttr<TargetDarwinNegative> {
   let Spellings = [GCC<"alias">];
----------------
rsmith wrote:
> Is this really specific to Darwin? I would expect it instead to be specific to the `ObjectFormat`. And I think listing the object formats that *do* support aliases seems reasonable (as there's only three of them to list -- assuming that WAsm actually supports aliases, which I don't know -- and we'd probably want future object file formats to opt in rather than opting out).
Hi,
   If using this program, we need to define a support alias platform, is not it? This platform needs to include the ArchType in the Triple.h file for the most part, and we need to set the ObjectFormatType to COFF, ELF, and Wasm. But we only want to exclude the few unsupported platforms. If my understanding is not right, please told me.


Repository:
  rC Clang

https://reviews.llvm.org/D46805