[PATCH] D45835: Add new driver mode for dumping compiler options

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added inline comments.


================
Comment at: lib/Frontend/FrontendActions.cpp:779
+  {
+    std::string Str;
+#define FEATURE(Name, Predicate)                                               \
----------------
aaron.ballman wrote:
> lebedev.ri wrote:
> > This is likely to do an allocation for each feature.
> > Maybe consider `llvm::SmallString<64>`
> 64 bytes seemed a bit tight, so I went with 128 instead. Likely still a bit too small, but shouldn't be too bad.
`FixedString` / `FixedVector` would be nice to have here.


https://reviews.llvm.org/D45835