[PATCH] D46740: [Clang Tablegen][RFC] Allow Early Textual Substitutions in `Diagnostic` messages.

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 12 22:47:38 PDT 2018


EricWF added a comment.

In https://reviews.llvm.org/D46740#1097014, @rsmith wrote:

> Thanks, this is great.
>
> In https://reviews.llvm.org/D46740#1096859, @EricWF wrote:
>
> > Turns out we have to fully parse the diagnostic text in order to substitute modifier indexes, which is a bit of a complication. This patch does exactly that.
>
>
> I like that you were able to reuse the existing parsing code for documentation generation here.


With heavy modifications  :-)


https://reviews.llvm.org/D46740





More information about the cfe-commits mailing list