[PATCH] D46740: [Clang Tablegen][RFC] Allow Early Textual Substitutions in `Diagnostic` messages.

[Eric Fiselier via Phabricator via cfe-commits]

EricWF added a comment.

@rsmith Can select indexes be negative? What's the correct type to represent them? Existing code seems to use `int`, but the LLVM style seems to suggest `unsigned` is more appropriate.



================
Comment at: utils/TableGen/ClangDiagnosticsEmitter.cpp:591
+  std::vector<unsigned> Modifiers;
+  Piece *Substitution = nullptr;
+
----------------
This is unused. Removing.


https://reviews.llvm.org/D46740