[PATCH] D46758: [clang-format] Move #include related style to libToolingCore

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 11 09:33:45 PDT 2018


ilya-biryukov added inline comments.


================
Comment at: lib/Format/Format.cpp:461
+
+template <> struct MappingTraits<IncludeStyle::IncludeCategory> {
+  static void mapping(IO &IO, IncludeStyle::IncludeCategory &Category) {
----------------
Should we move this to `tooling::Core` too?
If we need to specialize `MappingTraits`, we should probably do it close to the class definitions. To avoid accidental ODR violations...


Repository:
  rC Clang

https://reviews.llvm.org/D46758





More information about the cfe-commits mailing list