[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri May 11 07:09:20 PDT 2018
ilya-biryukov added a subscriber: sammccall.
ilya-biryukov added a comment.
So, the first line of the file generated by proto compiler seems to be something like this:
// Generated by the protocol buffer compiler. DO NOT EDIT!
If we check the symbol comes from a file with this comment, there will be zero chance that we guess it wrong.
And we can always filter, in addition to the user-provided filters that @malaperle proposed (which also sound like a very useful feature to me!)
@ioeric, @malaperle, @sammccall, WDYT?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46751
More information about the cfe-commits
mailing list