[PATCH] D46643: CodeGen: Emit string literal in constant address space
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 9 11:30:41 PDT 2018
rjmccall added a comment.
The part about string literals looks fine, but:
================
Comment at: lib/CodeGen/CGDecl.cpp:1375
+ Loc = Address(EmitCastToVoidPtrInAllocaAddrSpace(Loc.getPointer()),
+ Loc.getAlignment());
----------------
I don't understand why a patch about string literals is changing auto variable emission.
https://reviews.llvm.org/D46643
More information about the cfe-commits
mailing list